New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX deprecated call to Tools::replaceByAbsoluteURL #10182

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@axometeam
Contributor

axometeam commented Aug 29, 2018

Questions Answers
Branch? develop
Description? Deprecated call to Tools::replaceByAbsoluteURL
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? With 1.6.1.20 ans PHP errors displayed (PS_MODE_DEV is on), enable CSS compression in the "Performances" settings. Clear cache, then go to FO: you should see the PHP error messages.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 29, 2018

@marionf marionf self-assigned this Aug 30, 2018

@marionf marionf removed the waiting for QA label Aug 30, 2018

@marionf marionf removed their assignment Aug 30, 2018

@marionf marionf added the QA ✔️ label Aug 30, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit f4f66c5 into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 31, 2018

Thank you @axometeam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment