New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back Addons Catalog controller #10200

Merged
merged 7 commits into from Aug 31, 2018

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 29, 2018

Questions Answers
Branch? develop
Description? Bring back the controller AddonsCatalog removed one month ago. Fixes upgrade of #9454
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #10203
How to test? Module catalog should be back, whatever you install or you upgrade your shop

This change is Reviewable

@@ -67,7 +67,7 @@ public function catalogAction()
'PrestaShopBundle:Admin/Module:catalog.html.twig',
[
'layoutHeaderToolbarBtn' => $this->getToolbarButtons(),
'layoutTitle' => $this->trans('Module selection', 'Admin.Navigation.Menu'),
'layoutTitle' => $this->trans('Modules catalog', 'Admin.Navigation.Menu'),

This comment has been minimized.

@PierreRambaud

PierreRambaud Aug 30, 2018

Contributor

Should it be Module catalog?

@PierreRambaud

PierreRambaud Aug 30, 2018

Contributor

Should it be Module catalog?

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Aug 30, 2018

Member

I kept the previous title from AddonsStoreController (look here a481135#diff-42da191bd5eec313d41734188486e993R52)

@Quetzacoalt91

Quetzacoalt91 Aug 30, 2018

Member

I kept the previous title from AddonsStoreController (look here a481135#diff-42da191bd5eec313d41734188486e993R52)

@marionf marionf self-assigned this Aug 30, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 30, 2018

@marionf marionf removed their assignment Aug 30, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 31, 2018

Contributor

giphy

Thanks!

Contributor

mickaelandrieu commented Aug 31, 2018

giphy

Thanks!

@mickaelandrieu mickaelandrieu merged commit 79b6a8c into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment