New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when saving memcached configuration #10201

Merged
merged 1 commit into from Aug 30, 2018

Conversation

Projects
None yet
7 participants
@PierreRambaud
Contributor

PierreRambaud commented Aug 29, 2018

Questions Answers
Branch? develop
Description? - Refactor variables names
- Check if getVersion is an array
- Wrong condition in js
- Use const for http codes
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9542
How to test? Follow ticket instruction.

This change is Reviewable

Errors when saving memcached configuration
- Refactor variables names
- Check if getVersion is an array
- Wrong condition in js
@matks

matks approved these changes Aug 30, 2018

@matks matks merged commit e5ace89 into PrestaShop:develop Aug 30, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/memcached-9542 branch Aug 30, 2018

@dritancami

This comment has been minimized.

Show comment
Hide comment
@dritancami

dritancami Sep 11, 2018

I have applied the changes approved by @matks, but the problem is not solved.

dritancami commented Sep 11, 2018

I have applied the changes approved by @matks, but the problem is not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment