New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'edit specific price' modal behavior bugs and display #10202

Merged
merged 3 commits into from Sep 7, 2018

Conversation

Projects
None yet
5 participants
@matks
Contributor

matks commented Aug 29, 2018

Questions Answers
Branch? develop
Description? Fixes 'edit specific price' modal behavior bugs and bad display
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10175
How to test? The bugs list is in the Issue. No behavior described in the Issue should remain with this PR, everything should be fixed.

This change is Reviewable

@matks matks added this to the 1.7.5.0 milestone Aug 29, 2018

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Sep 3, 2018

Contributor

Fixes #10175

Contributor

matks commented Sep 3, 2018

Fixes #10175

@marionf marionf self-assigned this Sep 3, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 4, 2018

Contributor

@matks

Just a last thing: When I edit a specific price in %, I see the tax incl/tax excl drop down
It shouldn't be displayed if % is selected

capture d ecran_240

Otherwise, everything is good 👍

Contributor

marionf commented Sep 4, 2018

@matks

Just a last thing: When I edit a specific price in %, I see the tax incl/tax excl drop down
It shouldn't be displayed if % is selected

capture d ecran_240

Otherwise, everything is good 👍

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Sep 4, 2018

Contributor

Bug found by marionf fixed by 7f887b7
An additionnal modal bug fixed by 50d4c57

Need review for these 2 commits :)

Contributor

matks commented Sep 4, 2018

Bug found by marionf fixed by 7f887b7
An additionnal modal bug fixed by 50d4c57

Need review for these 2 commits :)

@@ -154,6 +154,7 @@ class SpecificPriceFormHandler {
var selectorPrefix = this.getPrefixSelector(usePrefixForCreate);
$('#form_modal_cancel').click(() => this.closeEditPriceModalAndRemoveForm());
$('#form_modal_close').click(() => this.closeEditPriceModalAndRemoveForm());

This comment has been minimized.

@PierreRambaud

PierreRambaud Sep 7, 2018

Contributor

You also can do this, but not mandatory.
$('#form_modal_cancel, #form_modal_close').on('click', (() =>...

@PierreRambaud

PierreRambaud Sep 7, 2018

Contributor

You also can do this, but not mandatory.
$('#form_modal_cancel, #form_modal_close').on('click', (() =>...

@matks matks added the waiting for QA label Sep 7, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 7, 2018

@marionf marionf removed their assignment Sep 7, 2018

@PierreRambaud PierreRambaud merged commit 43cd8ba into PrestaShop:develop Sep 7, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 7, 2018

Contributor

Thanks @matks

Contributor

PierreRambaud commented Sep 7, 2018

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment