New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voucher button is too long in Cart #10207

Merged
merged 2 commits into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@CaptainYouz
Contributor

CaptainYouz commented Aug 30, 2018

Questions Answers
Branch? develop
Description? This PR fix the display in FO > Cart > Voucher Button for cases where text inside the voucher button is to long and go to the line.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9912
How to test? Check before/after and look for other cases where vucher button text is too long.

This change is Reviewable

@PierreRambaud PierreRambaud changed the title from Issue 9912 voucher button to Voucher button is too long in Cart Aug 30, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 30, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 31, 2018

Contributor

QA approved and reviewed => LGTM

Good job @CaptainYouz and thanks for reviews

Contributor

mickaelandrieu commented Aug 31, 2018

QA approved and reviewed => LGTM

Good job @CaptainYouz and thanks for reviews

@mickaelandrieu mickaelandrieu merged commit fd4a937 into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@CaptainYouz CaptainYouz deleted the CaptainYouz:issue-9912_voucher-button branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment