New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix falsy value returned by upgrade script #10218

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 30, 2018

Questions Answers
Branch? develop
Description? An upgrade script was flagged with ERROR, even if everything went fine. That was caused by a wrong default value.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? #9513 partially, #9487 and follows up #8556 (comment)
How to test? Upgrade from PrestaShop 1.6. This script should be reported in error during the process in the step UpgradeDb. With this PR, it should get a OK.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 30, 2018

@marionf marionf self-assigned this Aug 31, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 31, 2018

@marionf marionf removed their assignment Aug 31, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 31, 2018

Contributor

QA approved and reviewed => LGTM

Good job everyone!

Contributor

mickaelandrieu commented Aug 31, 2018

QA approved and reviewed => LGTM

Good job everyone!

@mickaelandrieu mickaelandrieu merged commit 8e35a4b into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment