New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO | Product Page: fix visual glitches in categories filter #10221

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@CaptainYouz
Contributor

CaptainYouz commented Aug 31, 2018

Questions Answers
Branch? develop
Description? This PR fixes the visual glitch in Product Page > Categories Filter, when switching on RTL languages
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9755
How to test? Check before/after

This change is Reviewable

@CaptainYouz CaptainYouz changed the title from ui(BO | Product Page): fix visual glitches in categories filter to BO | Product Page: fix visual glitches in categories filter Aug 31, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 3, 2018

Member

Have you checked there's no additional changes to bring in admin-dev/themes/default/public/theme.rtlfix?

Member

Quetzacoalt91 commented Sep 3, 2018

Have you checked there's no additional changes to bring in admin-dev/themes/default/public/theme.rtlfix?

@CaptainYouz

This comment has been minimized.

Show comment
Hide comment
@CaptainYouz

CaptainYouz Sep 3, 2018

Contributor

@Quetzacoalt91 yes, there's no additional changes to bring in admin-dev/themes/default/public/theme.rtlfix

Contributor

CaptainYouz commented Sep 3, 2018

@Quetzacoalt91 yes, there's no additional changes to bring in admin-dev/themes/default/public/theme.rtlfix

@marionf marionf self-assigned this Sep 3, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 4, 2018

@marionf marionf removed their assignment Sep 4, 2018

@marionf marionf added this to the 1.7.5.0 milestone Sep 4, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit e9d7fd7 into PrestaShop:develop Sep 4, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 4, 2018

Thank you @CaptainYouz

@CaptainYouz CaptainYouz deleted the CaptainYouz:issue-9755_RTL_visual_glitches branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment