New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DB backup page #10223

Merged
merged 3 commits into from Sep 4, 2018

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Aug 31, 2018

Questions Answers
Branch? develop
Description? DB backup page was not updated using new interfaces
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Access Configure > Advanced Parameters > Database then Backup tab

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 31, 2018

@marionf marionf self-assigned this Aug 31, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Aug 31, 2018

@marionf marionf removed their assignment Aug 31, 2018

@mickaelandrieu mickaelandrieu referenced this pull request Aug 31, 2018

Merged

Minor grid improvements #10219

5 of 5 tasks complete
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 31, 2018

Contributor

Hi @LouiseBonnard, this translation key was not found:

"Check the maximum filesize allowed (e.g. Max: 16MB)" in "AdminAdvparametersHelp" domain, even in fallback catalog.

What do we do?

Contributor

mickaelandrieu commented Aug 31, 2018

Hi @LouiseBonnard, this translation key was not found:

"Check the maximum filesize allowed (e.g. Max: 16MB)" in "AdminAdvparametersHelp" domain, even in fallback catalog.

What do we do?

@LouiseBonnard

This comment has been minimized.

Show comment
Hide comment
@LouiseBonnard

LouiseBonnard Aug 31, 2018

Contributor

@mickaelandrieu, the translation key is currently localized in the messages.xlf file. Since it is better to assign domains to it, let's just keep it under Admin.Advparameters.Help if you're alright with that. :-)

Contributor

LouiseBonnard commented Aug 31, 2018

@mickaelandrieu, the translation key is currently localized in the messages.xlf file. Since it is better to assign domains to it, let's just keep it under Admin.Advparameters.Help if you're alright with that. :-)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 31, 2018

Contributor

@LouiseBonnard I do but because the current fallback catalog is not synced with our code, we are unable to retrieve the key and this makes the e2e test break: do you think we can update the translation pack? /c @eternoendless

Contributor

mickaelandrieu commented Aug 31, 2018

@LouiseBonnard I do but because the current fallback catalog is not synced with our code, we are unable to retrieve the key and this makes the e2e test break: do you think we can update the translation pack? /c @eternoendless

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 4, 2018

Contributor

@mickaelandrieu Is there something missing now?

Contributor

PierreRambaud commented Sep 4, 2018

@mickaelandrieu Is there something missing now?

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 4, 2018

Contributor

I don't think so 👍

Contributor

mickaelandrieu commented Sep 4, 2018

I don't think so 👍

@PierreRambaud PierreRambaud merged commit e9f222b into PrestaShop:develop Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the mickaelandrieu:fix/backup-page branch Sep 4, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment