New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CO: Fixed error with inheritance #10227

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
5 participants
@idnovate
Contributor

idnovate commented Aug 31, 2018

Questions Answers
Branch? develop
Description? Is not possible to extend function getCustomerCartRules() because it's called from getCustomerHighlightedDiscounts() as "self".
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Override function getCustomerCartRules(). Then add a trace at getCustomerHighlightedDiscounts(), parent getCustomerCartRules() and overrided getCustomerCartRules() functions. It always executes getCustomerHighlightedDiscounts() and parent getCustomerCartRules() functions, but not overrided getCustomerCartRules() function

This change is Reviewable

@marionf marionf self-assigned this Sep 3, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 3, 2018

@marionf marionf removed their assignment Sep 3, 2018

@PierreRambaud PierreRambaud merged commit 13e9101 into PrestaShop:develop Sep 3, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 3, 2018

Contributor

Thanks @idnovate

Contributor

PierreRambaud commented Sep 3, 2018

Thanks @idnovate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment