New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add magic methods on LazyArray classes for object-like use #10230

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 31, 2018

Questions Answers
Branch? develop
Description? Before getting a property, module are checking if they are using an array or an object. As LazyArray are obviously considered as object, existing tests automatically get the properties accordingly. This PR covers this use case.
Type? bug fix
Category? FO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Install the module ps_productinfo and go to a product page. Without this PR, you will have the following error:

capture du 2018-08-31 14-47-05


This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 31, 2018

@ntiepresta ntiepresta self-assigned this Aug 31, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Aug 31, 2018

@ntiepresta ntiepresta removed their assignment Aug 31, 2018

@PierreRambaud PierreRambaud merged commit a079783 into PrestaShop:develop Aug 31, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment