New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PHP_BINARY while using createTestDb #10249

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
4 participants
@PierreRambaud
Contributor

PierreRambaud commented Sep 3, 2018

Questions Answers
Branch? develop
Description? Without this, it use the default php binary from $PATH which can be different if you use many php versions on your system.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? Waiting for CI.

This change is Reviewable

Use PHP_BINARY while using createTestDb
Without this, it use the default php binary from $PATH which can be
different if you use many php versions on your system.
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 3, 2018

Member

Do we need a QA review on this one?

Member

Quetzacoalt91 commented Sep 3, 2018

Do we need a QA review on this one?

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 3, 2018

Contributor

Not sure QA can validate this :/

Contributor

PierreRambaud commented Sep 3, 2018

Not sure QA can validate this :/

@Quetzacoalt91 Quetzacoalt91 merged commit 14d9f1d into PrestaShop:develop Sep 3, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 3, 2018

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:improvement/php-version branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment