New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help sidebar not working in the Stock page #10260

Merged
merged 3 commits into from Sep 4, 2018

Conversation

Projects
None yet
7 participants
@CaptainYouz
Contributor

CaptainYouz commented Sep 3, 2018

Questions Answers
Branch? develop
Description? This PR add enableSidebar and help_link vars into Stock Controller, to render the help button in the layout
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9776
How to test? Go to Stock page and click on the help button.

This change is Reviewable

@CaptainYouz

This comment has been minimized.

Show comment
Hide comment
@CaptainYouz

CaptainYouz Sep 3, 2018

Contributor

As seen with @eternoendless , this PR is a temporary fix to display the help sidebar. It needs to have a deeper change, for giving the Vue Stock app the right help url (depending on stock or movement tab).

Contributor

CaptainYouz commented Sep 3, 2018

As seen with @eternoendless , this PR is a temporary fix to display the help sidebar. It needs to have a deeper change, for giving the Vue Stock app the right help url (depending on stock or movement tab).

@CaptainYouz CaptainYouz changed the title from back(BO | Stock): change stock controller to add help_link and enable… to BO | Stock: change stock controller to add help_link and enable… Sep 3, 2018

@CaptainYouz CaptainYouz changed the title from BO | Stock: change stock controller to add help_link and enable… to BO | Stock: change of stock controller to add help_link and enable… Sep 3, 2018

@marionf marionf self-assigned this Sep 3, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 3, 2018

Contributor

@CaptainYouz

I have this

capture d ecran_238

Do you think we can add an header "Help", a "close" cross and the title "Stock overview" in pink like on the product page below ?

capture d ecran_235

Contributor

marionf commented Sep 3, 2018

@CaptainYouz

I have this

capture d ecran_238

Do you think we can add an header "Help", a "close" cross and the title "Stock overview" in pink like on the product page below ?

capture d ecran_235

@CaptainYouz

This comment has been minimized.

Show comment
Hide comment
@CaptainYouz

CaptainYouz Sep 3, 2018

Contributor

@marionf it was a visual bug. Fixed in e4b88a7

Contributor

CaptainYouz commented Sep 3, 2018

@marionf it was a visual bug. Fixed in e4b88a7

@@ -4,7 +4,7 @@
top: $size-header-height;
left: $size-navbar-width;
right: 0;
z-index: 501;
z-index: 1;

This comment has been minimized.

@CaptainYouz

CaptainYouz Sep 3, 2018

Contributor

Reduce z-index to 1. I think it was previously added because of: fbc6444#diff-f9b1e580902f493368ce09e8a713d3a3

@CaptainYouz

CaptainYouz Sep 3, 2018

Contributor

Reduce z-index to 1. I think it was previously added because of: fbc6444#diff-f9b1e580902f493368ce09e8a713d3a3

@eternoendless eternoendless changed the title from BO | Stock: change of stock controller to add help_link and enable… to Fix help sidebar not working in the Stock page Sep 3, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 3, 2018

Member

I think that the pink title not appearing is an issue on the help platform.

Member

eternoendless commented Sep 3, 2018

I think that the pink title not appearing is an issue on the help platform.

@eternoendless eternoendless added this to the 1.7.5.0 milestone Sep 3, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 4, 2018

@marionf marionf removed their assignment Sep 4, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 4, 2018

Member

@CaptainYouz, can you please rebase to regenerate the assets?

Member

Quetzacoalt91 commented Sep 4, 2018

@CaptainYouz, can you please rebase to regenerate the assets?

@CaptainYouz

This comment has been minimized.

Show comment
Hide comment
@CaptainYouz
Contributor

CaptainYouz commented Sep 4, 2018

@Quetzacoalt91 done in e086d7d
:)

@Quetzacoalt91 Quetzacoalt91 merged commit 512f29e into PrestaShop:develop Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 4, 2018

Thank you @CaptainYouz

@CaptainYouz CaptainYouz deleted the CaptainYouz:issue-9776_incorrect_help_display branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment