New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pre-commit hook script #10287

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
5 participants
@mickaelandrieu
Contributor

mickaelandrieu commented Sep 4, 2018

Questions Answers
Branch? develop
Description? Using "composer git-hook-install" produces no results at all, now it installs the git hook as expected.
Type? bug fix
Category? CO
BC breaks? Dno
Deprecations? no
How to test? Do "composer git-hook-install", you should see a message of success"

proff


This change is Reviewable

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 5, 2018

Contributor

Other things are broken with this hook, I will update your PR in few minutes.

Contributor

PierreRambaud commented Sep 5, 2018

Other things are broken with this hook, I will update your PR in few minutes.

Fix errors with hooks
- Do not use APPEND because of shebang in our file, a back file is
  automatically generated when running git-hook-install command
- Change tabs in spaces
- Use an sh way to get the current path
- Use which php to detect php PATH

@matks matks self-assigned this Sep 5, 2018

@matks

matks approved these changes Sep 5, 2018

@tomlev

tomlev approved these changes Sep 5, 2018

@matks matks merged commit d6723d8 into PrestaShop:develop Sep 5, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu deleted the mickaelandrieu:fix/pre-commit-hook branch Sep 5, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Sep 5, 2018

@matks matks removed their assignment Sep 7, 2018

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Sep 7, 2018

Contributor

Thank you @mickaelandrieu

Contributor

matks commented Sep 7, 2018

Thank you @mickaelandrieu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment