New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the display of textarea in the category page #10291

Merged
merged 4 commits into from Sep 12, 2018

Conversation

Projects
None yet
7 participants
@khouloudbelguith
Contributor

khouloudbelguith commented Sep 5, 2018

Questions Answers
Branch? develop
Description? When trying to edit the category, the textarea of the meta description is wrongly displayed.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9915
How to test? Navigate to BO > Catalog > Categories > Edit a category and check if the textarea of the meta description is correctly displayed.

This change is Reviewable

@matks matks added the waiting for QA label Sep 7, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 7, 2018

Contributor

@khouloudbelguith

We have a bad display at the bottom of the page:

capture d ecran_284

It sould be like this:

capture d ecran_285

Contributor

marionf commented Sep 7, 2018

@khouloudbelguith

We have a bad display at the bottom of the page:

capture d ecran_284

It sould be like this:

capture d ecran_285

@khouloudbelguith

This comment has been minimized.

Show comment
Hide comment
@khouloudbelguith

khouloudbelguith Sep 10, 2018

Contributor

Hi @marionf,

Done :)
Thanks to check it.

Best regards, Khouloud

Contributor

khouloudbelguith commented Sep 10, 2018

Hi @marionf,

Done :)
Thanks to check it.

Best regards, Khouloud

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 12, 2018

Contributor

LGTM, thanks @khouloudbelguith and @ntiepresta for the QA validation.

Contributor

mickaelandrieu commented Sep 12, 2018

LGTM, thanks @khouloudbelguith and @ntiepresta for the QA validation.

@mickaelandrieu mickaelandrieu merged commit 3680e80 into PrestaShop:develop Sep 12, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Sep 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment