New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum order amount for secondary currency #10294

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
6 participants
@sadlyblue
Copy link
Contributor

sadlyblue commented Sep 5, 2018

Fix for #9665 [BOOM-5355]
Switched from convertAmount to format amount for $productsTotalExcludingTax (cart already returns value in correct currency), and $minimalPurchase only needs to be converted to current currency once.

Questions Answers
Branch? develop
Description? When not using FO with default currency, it cause issues with minimum order value as described in #9665 [BOOM-5355]
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9665
How to test? Set minimum order amount. Create secondary currency with rate lower than 1 (0.1 is great for test). Add products to cart, and check the behaviour. Before this fix, it would incorrectly signal carts, and display a wrong value for minimum order amount.

This change is Reviewable

Fix minimum order amount for secondary currency
Fix for #9665 [BOOM-5355]
Switched from convertAmount to format amount for $productsTotalExcludingTax (cart already returns value in correct currency), and $minimalPurchase only needs to be converted to current currency once.
@Comanche-aLike

This comment has been minimized.

Copy link

Comanche-aLike commented Nov 28, 2018

Will this solution work with 1.7.2.5 version?

@eternoendless eternoendless added this to the 1.7.6.0 milestone Jan 2, 2019

@prestonBot prestonBot added the develop label Jan 2, 2019

@marionf marionf removed the 1.7.4.x label Jan 2, 2019

@marionf marionf self-assigned this Jan 2, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 2, 2019

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Jan 3, 2019

Thank you @sadlyblue

@eternoendless eternoendless merged commit 8680c34 into PrestaShop:develop Jan 3, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@prestasho

This comment has been minimized.

Copy link

prestasho commented Jan 6, 2019

Thank you @sadlyblue

thanks!!!
but in the blockcart shows the wrong total amount (the default currency is correct)
please tell me how to fix it
default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment