New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image dimensions in Product Card view #10297

Merged
merged 8 commits into from Jan 5, 2019

Conversation

@CaptainYouz
Copy link
Contributor

CaptainYouz commented Sep 5, 2018

Questions Answers
Branch? develop
Description? This PR change the UI of the product image on the card view by removing margin.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9738
How to test? Check visual before/after

This change is Reviewable

@CaptainYouz CaptainYouz changed the title Issue 9738 product card image dimension FO | Product Card view: fix image dimension Sep 5, 2018

@CaptainYouz CaptainYouz changed the title FO | Product Card view: fix image dimension FO | Product Card View: fix image dimension Sep 5, 2018

@matks matks added the waiting for QA label Sep 7, 2018

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Sep 7, 2018

@CaptainYouz

Before when the image was smaller we had this:

capture d ecran_287

Now, we have this:

capture d ecran_288

We should keep the previous behavior and center the image

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Jan 3, 2019

When the image is smaller, it' ok it's well centered

capture d ecran_846

But the original issue is not fixed, cards are still too big

capture d ecran_847

@PierreRambaud PierreRambaud force-pushed the CaptainYouz:issue-9738_product-card-image-dimension branch from 5726ce7 to 5642e5a Jan 4, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 4, 2019

@marionf Should be ok now, I'm sorry :/

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Jan 4, 2019

Yes, it's all good thank you @PierreRambaud

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 4, 2019

@eternoendless eternoendless changed the title FO | Product Card View: fix image dimension Fix image dimensions in Product Card view Jan 4, 2019

@eternoendless eternoendless self-assigned this Jan 4, 2019

@eternoendless eternoendless force-pushed the CaptainYouz:issue-9738_product-card-image-dimension branch from 5642e5a to 9c89df3 Jan 4, 2019

Fixed issue

@eternoendless eternoendless force-pushed the CaptainYouz:issue-9738_product-card-image-dimension branch from 9c89df3 to b8f83c7 Jan 4, 2019

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Jan 4, 2019

Before PR:

Before

After PR:

After

@eternoendless eternoendless removed the QA ✔️ label Jan 4, 2019

@marionf marionf added the QA ✔️ label Jan 4, 2019

@PierreRambaud PierreRambaud merged commit 7cc55d7 into PrestaShop:develop Jan 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 5, 2019

Thanks everyone :)

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment