New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for Webservice list #10311

Merged
merged 11 commits into from Sep 12, 2018

Conversation

Projects
None yet
5 participants
@tomas862
Contributor

tomas862 commented Sep 6, 2018

Questions Answers
Branch? develop
Description? I added small improvements regarding file naming, missing dockblocks and other stuff regarding code quality. This PR is related with #10208 comments made by @sarjon.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? Page can be reached via admin-dev/index.php/configure/advanced/webservice/ and these changes impacts list only. It should work the same as it was in #10208

This change is Reviewable

@mickaelandrieu

small update of service name expected

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 10, 2018

Contributor

Hello @tomas862,

sorry for the delay, would you mind to rebase so I can add the "waiting for QA" label?

Thanks

Contributor

mickaelandrieu commented Sep 10, 2018

Hello @tomas862,

sorry for the delay, would you mind to rebase so I can add the "waiting for QA" label?

Thanks

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 11, 2018

Contributor

Hello, let's validate this by QA.

Once it's ok, I'll build assets again.

Mickaël

Contributor

mickaelandrieu commented Sep 11, 2018

Hello, let's validate this by QA.

Once it's ok, I'll build assets again.

Mickaël

@tomas862

This comment has been minimized.

Show comment
Hide comment
@tomas862

tomas862 Sep 11, 2018

Contributor

Hello @mickaelandrieu - I can rebase this Pull request this evening, thanks for review :)

Contributor

tomas862 commented Sep 11, 2018

Hello @mickaelandrieu - I can rebase this Pull request this evening, thanks for review :)

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 11, 2018

Contributor

Hello @tomas862, let's wait for QA approval first :)

Contributor

mickaelandrieu commented Sep 11, 2018

Hello @tomas862, let's wait for QA approval first :)

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 12, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Sep 12, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 12, 2018

Contributor

Good job @tomas862!

Contributor

mickaelandrieu commented Sep 12, 2018

Good job @tomas862!

@mickaelandrieu mickaelandrieu merged commit c760d21 into PrestaShop:develop Sep 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tomas862 tomas862 deleted the tomas862:improvements/migration_grid branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment