New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded-version in assets URL #10337

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 7, 2018

Questions Answers
Branch? develop
Description? We remove an hardcoded version in the assets URL, which prevent the new files to be loaded after an upgrade.
Type? bug fix
Category? CO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #10330
How to test? Go to a Symfony related page, and check the assets in the browser developper tools, network tab. You should get the current PS version in the URL

capture du 2018-09-07 11-21-29


This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Sep 7, 2018

@Quetzacoalt91 Quetzacoalt91 changed the title from Remove hard-coded-version in assets to Remove hard-coded-version in assets URL Sep 7, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 7, 2018

Contributor

Nice catch!

Contributor

PierreRambaud commented Sep 7, 2018

Nice catch!

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 10, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 847c9c1 into PrestaShop:develop Sep 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:use-ps-version-in-assets branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment