New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main page slider display on all devices #10341

Merged
merged 3 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@CaptainYouz
Copy link
Contributor

CaptainYouz commented Sep 7, 2018

Questions Answers
Branch? develop
Description? This PR fixes the display (on small devices) of the slider in the main page of FO theme.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9614
How to test? Check the display on different browser and browser size.

This change is Reviewable

@CaptainYouz

This comment has been minimized.

Copy link
Contributor Author

CaptainYouz commented Sep 7, 2018

All visual changes approved by @TristanLDD .

@CaptainYouz CaptainYouz changed the title ui(FO | Main Page | Slider): fix slider display on all devices. #9614 FO | Main Page | Slider: fix slider display on all devices Sep 7, 2018

}
}
}
}

This comment has been minimized.

@PierreRambaud

PierreRambaud Sep 7, 2018

Contributor

Missing new line at the end of file.

This comment has been minimized.

@CaptainYouz

CaptainYouz Sep 10, 2018

Author Contributor

@CaptainYouz CaptainYouz referenced this pull request Sep 10, 2018

Open

#9614 BOOM-5805 #10334

@eternoendless eternoendless force-pushed the CaptainYouz:issue-9614_fo_main_slider branch from 15e7d09 to 7ac1902 Jan 14, 2019

@eternoendless eternoendless changed the title FO | Main Page | Slider: fix slider display on all devices Fix main page slider display on all devices Jan 14, 2019

@eternoendless
Copy link
Member

eternoendless left a comment

Rebased

@eternoendless eternoendless added this to the 1.7.6.0 milestone Jan 14, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 14, 2019

@PierreRambaud PierreRambaud merged commit 0eb62bf into PrestaShop:develop Jan 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 15, 2019

Thanks everyone ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment