New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix htaccess to support Apache 2.4 webservers #10347

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
6 participants
@gennaris
Contributor

gennaris commented Sep 7, 2018

Questions Answers
Branch? develop
Description? This file was not updated to support Apache 2.4 webservers, causing resources in /translations/cldr/ being refused because of updated parent .htaccess
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? N/A
How to test? Try accessing "http://fo.demo.prestashop.com/translations/cldr/datas/main/en-GB/currencies.json" from your own demo website, you will see 403 forbidden - but those resources should be accessed by backoffice like in previous PS versions.

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 7, 2018

Collaborator

Hello @gennaris!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Sep 7, 2018

Hello @gennaris!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 7, 2018

Contributor

Nice catch, thinking every .htaccess files were updating oO

Contributor

PierreRambaud commented Sep 7, 2018

Nice catch, thinking every .htaccess files were updating oO

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Sep 8, 2018

Contributor

.htaccess same for var folder :trollface:

Contributor

Mreker commented Sep 8, 2018

.htaccess same for var folder :trollface:

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Sep 8, 2018

Contributor

I fixed it here: #10352

Contributor

Mreker commented Sep 8, 2018

I fixed it here: #10352

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 10, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Sep 10, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit b8091fb into PrestaShop:develop Sep 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 10, 2018

Thank you @gennaris

@jolelievre jolelievre changed the title from FO: Fix htaccess to support Apache 2.4 webservers to Fix htaccess to support Apache 2.4 webservers Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment