New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty row when social title is empty #10350

Merged
merged 4 commits into from Sep 11, 2018

Conversation

Projects
None yet
5 participants
@Mreker
Contributor

Mreker commented Sep 8, 2018

Questions Answers
Branch? develop
Description? When you do not have any social titles on your shop, you will have a empty line on FO. This PR fix this.
Type? bug fix
Category? FO
BC breaks? No
Deprecations? No
Fixed ticket? ?
How to test? Delete all social titles in BO and try to create a customer in FO.

This change is Reviewable

Mreker added some commits Sep 8, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 10, 2018

Member

Hmm, does removing the field makes the form validation pass?

Member

Quetzacoalt91 commented Sep 10, 2018

Hmm, does removing the field makes the form validation pass?

@Mreker

This comment has been minimized.

Show comment
Hide comment
@Mreker

Mreker Sep 10, 2018

Contributor

@Quetzacoalt91 Please test this solution. I works, and I see no problems.

Contributor

Mreker commented Sep 10, 2018

@Quetzacoalt91 Please test this solution. I works, and I see no problems.

@Mreker Mreker closed this Sep 10, 2018

@Mreker Mreker reopened this Sep 10, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 11, 2018

@Quetzacoalt91 Quetzacoalt91 referenced this pull request Sep 11, 2018

Closed

Social title field #9263

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Sep 11, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit df8cab5 into PrestaShop:develop Sep 11, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 11, 2018

Thank you @Mreker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment