New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list and settings layout #10358

Merged
merged 3 commits into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Member

sarjon commented Sep 10, 2018

Questions Answers
Branch? develop
Description? When list and settings are in the same page, then settings block width should be the same as list.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? "Advanced parameters > Email" and "Advanced parameters > Logs" pages where updated so configuration forms have the same width as lists.

This change is Reviewable

sarjon added some commits Sep 10, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 10, 2018

@@ -25,7 +25,7 @@
{% trans_default_domain 'Admin.Advparameters.Feature' %}
{% block email_configuration %}
<div class="col-xl-10">
<div class="col-12">

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 10, 2018

Member

Isn't col enough for using the whole width?

@Quetzacoalt91

Quetzacoalt91 Sep 10, 2018

Member

Isn't col enough for using the whole width?

This comment has been minimized.

@sarjon

sarjon Sep 10, 2018

Member

i've updated with col where possible. If you use 2 or more col in same row, they wont take up all width.

@sarjon

sarjon Sep 10, 2018

Member

i've updated with col where possible. If you use 2 or more col in same row, they wont take up all width.

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 10, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 5391244 into PrestaShop:develop Sep 10, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 10, 2018

Thank you @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment