New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined method in query parser #10363

Merged
merged 5 commits into from Sep 10, 2018

Conversation

Projects
None yet
4 participants
@sarjon
Member

sarjon commented Sep 10, 2018

Questions Answers
Branch? develop
Description? parseNumericParameter was left used but undefined, this PR fixes it.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Tests where updated and build should pass

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 10, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 10, 2018

Contributor

added the waiting for QA label

How can they test that?

Contributor

mickaelandrieu commented Sep 10, 2018

added the waiting for QA label

How can they test that?

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 10, 2018

Contributor

@mickaelandrieu Hum, they currently can't. :)

Contributor

PierreRambaud commented Sep 10, 2018

@mickaelandrieu Hum, they currently can't. :)

@PierreRambaud PierreRambaud merged commit db6910a into PrestaShop:develop Sep 10, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 10, 2018

Contributor

Thanks @sarjon

Contributor

PierreRambaud commented Sep 10, 2018

Thanks @sarjon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment