New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML purifier #10376

Merged
merged 3 commits into from Sep 20, 2018

Conversation

@MathiasReker
Contributor

MathiasReker commented Sep 11, 2018

Questions Answers
Branch? develop
Description? Update to latest version of HTMLPurifier v. 4.10.0. Since old version some bugs are solved and it is compatible with PHP 7.2.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #10128 and #9685
How to test? Test HTML Purifier by running composer install, and modify the content of a text field with TinyMce

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 11, 2018

Contributor

Yes!! Thanks @Mreker!
@ttoine can you check the license please?
@mickaelandrieu @Quetzacoalt91 if you know how HTML purifier work :)

Contributor

PierreRambaud commented Sep 11, 2018

Yes!! Thanks @Mreker!
@ttoine can you check the license please?
@mickaelandrieu @Quetzacoalt91 if you know how HTML purifier work :)

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 11, 2018

Member

Hi,

That's a open discussion I start here, but I see that HTML purifier is available through Composer (http://htmlpurifier.org/download#Composer).
That is probably a nice moment to remove it from our files and integrate it in our composer file?

Member

Quetzacoalt91 commented Sep 11, 2018

Hi,

That's a open discussion I start here, but I see that HTML purifier is available through Composer (http://htmlpurifier.org/download#Composer).
That is probably a nice moment to remove it from our files and integrate it in our composer file?

@MathiasReker

This comment has been minimized.

Show comment
Hide comment
@MathiasReker

MathiasReker Sep 11, 2018

Contributor

Fine with me, but I am not able to do it. I am not that skilled sorry.

Contributor

MathiasReker commented Sep 11, 2018

Fine with me, but I am not able to do it. I am not that skilled sorry.

@MathiasReker

This comment has been minimized.

Show comment
Hide comment
@MathiasReker

MathiasReker Sep 11, 2018

Contributor

Maybe it can wait? Now the HTMLPurifier is at least up to date.

Contributor

MathiasReker commented Sep 11, 2018

Maybe it can wait? Now the HTMLPurifier is at least up to date.

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 16, 2018

Contributor

WDYT @Quetzacoalt91? Should we merge this first, or do you have time to do the pull request using Composer?

Contributor

mickaelandrieu commented Sep 16, 2018

WDYT @Quetzacoalt91? Should we merge this first, or do you have time to do the pull request using Composer?

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 20, 2018

Member

I'll create another branch from your changes @Mreker and I let you know.

Member

Quetzacoalt91 commented Sep 20, 2018

I'll create another branch from your changes @Mreker and I let you know.

MathiasReker and others added some commits Sep 11, 2018

Update HTML Purifier to lastest version
Updated HTML Purifier and add index.php in each subfolder. Then I ran cs-fixer.
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 20, 2018

Member

Done, HtmlPurifier is now included with Composer.

Member

Quetzacoalt91 commented Sep 20, 2018

Done, HtmlPurifier is now included with Composer.

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Sep 20, 2018

Contributor

Seems ok for me, sending formular request and compliant with PHP 7.0.32.
@Quetzacoalt91 @eternoendless if anyone have a PHP 7.2 to confirm that is also compliant

Contributor

mbadrani commented Sep 20, 2018

Seems ok for me, sending formular request and compliant with PHP 7.0.32.
@Quetzacoalt91 @eternoendless if anyone have a PHP 7.2 to confirm that is also compliant

@mbadrani mbadrani added the QA ✔️ label Sep 20, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit ecaf712 into PrestaShop:develop Sep 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 20, 2018

Member

Thank you everybody for review, and @Mreker for having initiated this task.

Member

Quetzacoalt91 commented Sep 20, 2018

Thank you everybody for review, and @Mreker for having initiated this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment