New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when advanced stock management is enabled in Product Shipping page #10382

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
7 participants
@lozal2244
Contributor

lozal2244 commented Sep 11, 2018

Questions Answers
Branch? 1.7.5.x
Description? The filepath of the included template was wrong
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? enable the ps_configuration variable PS_ADVANCED_STOCK_MANAGEMENT with a "1" and then go to the "carriers" tab in a product and you will see a fatal error

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 12, 2018

Contributor

Hi @lozal2244, Can you tell us what exactly happened, and how to test? Thanks

Contributor

PierreRambaud commented Sep 12, 2018

Hi @lozal2244, Can you tell us what exactly happened, and how to test? Thanks

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 12, 2018

Contributor

Hi @lozal2244, Can you tell us what exactly happened, and how to test? Thanks

The filepath of the included template was wrong, you need to enable Advanced stock management in Product page.

Contributor

mickaelandrieu commented Sep 12, 2018

Hi @lozal2244, Can you tell us what exactly happened, and how to test? Thanks

The filepath of the included template was wrong, you need to enable Advanced stock management in Product page.

@mickaelandrieu mickaelandrieu changed the title from bug when advanced stock management is enabled to bug when advanced stock management is enabled in Product Shipping page Sep 12, 2018

@ntiepresta

This comment has been minimized.

Show comment
Hide comment
@ntiepresta

ntiepresta Sep 14, 2018

Hi @lozal2244 ,
I did not manage to reproduce the issue.
Could you please provide us with more info? We need more details to understand how we can reproduce your issue:
-screenshot
-debug mode report in an attachment file
-php error logs
-apache error log
-javascript console log .

Best regards, Reddy Ntie

ntiepresta commented Sep 14, 2018

Hi @lozal2244 ,
I did not manage to reproduce the issue.
Could you please provide us with more info? We need more details to understand how we can reproduce your issue:
-screenshot
-debug mode report in an attachment file
-php error logs
-apache error log
-javascript console log .

Best regards, Reddy Ntie

@lozal2244

This comment has been minimized.

Show comment
Hide comment
@lozal2244

lozal2244 Sep 14, 2018

Contributor

Hello, just enable the ps_configuration variable PS_ADVANCED_STOCK_MANAGEMENT with a "1" and then go to the "carriers" tab in a product and you will see a fatal error .

Contributor

lozal2244 commented Sep 14, 2018

Hello, just enable the ps_configuration variable PS_ADVANCED_STOCK_MANAGEMENT with a "1" and then go to the "carriers" tab in a product and you will see a fatal error .

@sarjon

This comment has been minimized.

Show comment
Hide comment
@sarjon

sarjon Sep 15, 2018

Member

just enable the ps_configuration variable PS_ADVANCED_STOCK_MANAGEMENT with a "1"

why do you need to enable it directly in database? i think "Advanced stock management" feature is dropped (even though there are code left) since 1.7.0.0 PrestaShop version?

Member

sarjon commented Sep 15, 2018

just enable the ps_configuration variable PS_ADVANCED_STOCK_MANAGEMENT with a "1"

why do you need to enable it directly in database? i think "Advanced stock management" feature is dropped (even though there are code left) since 1.7.0.0 PrestaShop version?

@lozal2244

This comment has been minimized.

Show comment
Hide comment
@lozal2244

lozal2244 Sep 15, 2018

Contributor

everything is on the prestashop core so if you enable it you can use a module to control stock in warehouses like storemanager from emagicone

Contributor

lozal2244 commented Sep 15, 2018

everything is on the prestashop core so if you enable it you can use a module to control stock in warehouses like storemanager from emagicone

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 17, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Sep 17, 2018

@ntiepresta ntiepresta added waiting for QA and removed QA ✔️ labels Sep 17, 2018

@ntiepresta

This comment has been minimized.

Show comment
Hide comment
@ntiepresta

ntiepresta Sep 18, 2018

Hello, @sarjon
For me, I don't manage to reproduce the issue, do you manage reproduce it?
Best regards, Reddy Ntie

ntiepresta commented Sep 18, 2018

Hello, @sarjon
For me, I don't manage to reproduce the issue, do you manage reproduce it?
Best regards, Reddy Ntie

@lozal2244

This comment has been minimized.

Show comment
Hide comment
@lozal2244

lozal2244 Sep 18, 2018

Contributor

You have to create warehouses in PS 1.7 too, I know you have not the interface but if you do it manually or with an external program like magic one, you will see this error.

Anyway the path is wrong as you can see in the modified line.

Please accept this it will be a good new for the community who is developing moduels or programs

Contributor

lozal2244 commented Sep 18, 2018

You have to create warehouses in PS 1.7 too, I know you have not the interface but if you do it manually or with an external program like magic one, you will see this error.

Anyway the path is wrong as you can see in the modified line.

Please accept this it will be a good new for the community who is developing moduels or programs

@eternoendless eternoendless changed the title from bug when advanced stock management is enabled in Product Shipping page to Bug when advanced stock management is enabled in Product Shipping page Sep 20, 2018

@prestonBot prestonBot added the develop label Sep 20, 2018

@eternoendless eternoendless changed the base branch from develop to 1.7.5.x Sep 21, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 21, 2018

Member

I'm accepting this PR because the path is wrong and the fix is valid. However, as others said, keep in mind that this feature is no longer supported in PrestaShop 1.7.

Member

eternoendless commented Sep 21, 2018

I'm accepting this PR because the path is wrong and the fix is valid. However, as others said, keep in mind that this feature is no longer supported in PrestaShop 1.7.

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless
Member

eternoendless commented Sep 21, 2018

Thank you @lozal2244

@eternoendless eternoendless merged commit ed3f1f2 into PrestaShop:1.7.5.x Sep 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lozal2244

This comment has been minimized.

Show comment
Hide comment
@lozal2244

lozal2244 Sep 21, 2018

Contributor

thank you, The stock based in warehouses is supported by PS 1.7 but they removed the interface to sell it sepparatly -> https://addons.prestashop.com/es/gestion-stock-proveedores/32549-prestashop-erp-advanced-stock.html

Contributor

lozal2244 commented Sep 21, 2018

thank you, The stock based in warehouses is supported by PS 1.7 but they removed the interface to sell it sepparatly -> https://addons.prestashop.com/es/gestion-stock-proveedores/32549-prestashop-erp-advanced-stock.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment