New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fixtures inconsistencies #10410

Merged
merged 4 commits into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@jocel1
Contributor

jocel1 commented Sep 12, 2018

Questions Answers
Branch? develop
Description? Fix inconsistencies in demo fixtures
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9733, Fixes #9705, Fixes #10333
How to test? check the fixed tickets and the data are not consistent

This change is Reviewable

@jocel1 jocel1 requested review from toutantic and eternoendless Sep 12, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 13, 2018

Contributor

@jocel1 Look like your need to update unit tests :/

Contributor

PierreRambaud commented Sep 13, 2018

@jocel1 Look like your need to update unit tests :/

@jocel1 jocel1 merged commit c236328 into PrestaShop:develop Sep 13, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jocel1 jocel1 added this to the 1.7.5.0 milestone Sep 13, 2018

@eternoendless eternoendless changed the title from fix fixtures inconsistencies to Fix fixtures inconsistencies Sep 19, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 19, 2018

Member

@jocel1 you should have waited for QA

Member

eternoendless commented Sep 19, 2018

@jocel1 you should have waited for QA

@jocel1

This comment has been minimized.

Show comment
Hide comment
@jocel1

jocel1 Sep 19, 2018

Contributor

@eternoendless totally agree, I figured out of my mistake and sent a message to marion just after the merge

Contributor

jocel1 commented Sep 19, 2018

@eternoendless totally agree, I figured out of my mistake and sent a message to marion just after the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment