New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perceived form horizontal alignment #10416

Merged
merged 3 commits into from Sep 14, 2018

Conversation

Projects
None yet
4 participants
@eternoendless
Member

eternoendless commented Sep 13, 2018

Questions Answers
Branch? develop
Description? The forms column ratio sometimes made it look like it was misaligned. This PR makes the fields column wider. Also, it adds vertical padding to the form, per @TristanLDD's request
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Open a migrated form

Before:

pablo prestashop local_admin-dev_index php_configure_shop_preferences_preferences__token zkzfp8mmjkf3xqflnah4vordmr8azz6tswpzxf1b_6e 3

After:

pablo prestashop local_admin-dev_index php_configure_shop_preferences_preferences__token zkzfp8mmjkf3xqflnah4vordmr8azz6tswpzxf1b_6e 2


This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Sep 13, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 14, 2018

Member

Thanks guys

Member

eternoendless commented Sep 14, 2018

Thanks guys

@eternoendless eternoendless merged commit fdd3a25 into PrestaShop:develop Sep 14, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:fix-form-ratio branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment