New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Javascript indent to 2 spaces, per AirBnb rules #10419

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
4 participants
@eternoendless
Member

eternoendless commented Sep 13, 2018

Questions Answers
Branch? develop
Description? The eslintrc file had the wrong indentation configuration, which was set to 4 spaces instead of 2. See Coding standards and and Whitespace.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? This PR is about linting, no test required

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.0 milestone Sep 13, 2018

@eternoendless eternoendless requested a review from PierreRambaud Sep 13, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 13, 2018

Contributor

Yeah, did it in my branch too :D

Contributor

PierreRambaud commented Sep 13, 2018

Yeah, did it in my branch too :D

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 13, 2018

Member

Thanks guys

Member

eternoendless commented Sep 13, 2018

Thanks guys

@eternoendless eternoendless merged commit a512877 into PrestaShop:develop Sep 13, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:fix-eslint-indent branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment