New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get link of the first ACTIVE tab in nav #10427

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 13, 2018

Questions Answers
Branch? develop
Description? Back-office side menu always get the first sub-tab link, even if it is disabled. This leads to unwanted results, which makes a tab disabled but still accessible.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes PrestaShop/ps_mbo#32
How to test? Install ps_mbo. The link IMPROVE > Modules > Modules catalog must now target a module controller instead a disabled core controller. No need to reinstall the module when applying the PR.

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 referenced this pull request Sep 13, 2018

Closed

MBO tree #32

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 14, 2018

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Sep 14, 2018

@PierreRambaud PierreRambaud merged commit 37ef7d0 into PrestaShop:develop Sep 14, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment