New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed onclick from URL column in BO Shop URLs #10435

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
4 participants
@alu-

alu- commented Sep 14, 2018

Questions Answers
Branch? develop
Description? Removed onclick from URL column in BO Shop URLs
Type? bug fix / improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Visit the BO Admin Shop URLs page and click on a URL in the list.

This change is Reviewable

Oskar Andersson
Removed onclick from URL column in BO Shop URLs
Previously the URL column in the BO multistore page had an onclick
attribute that would redirect the browser to the edit page for the URL.
This clashed with the actual content in the column being a hyperlink
that takes the browser to the shops URL.

This commit removes the onclick attribute for that column cell.
@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Sep 14, 2018

Collaborator

Hello @alu-!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Sep 14, 2018

Hello @alu-!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Sep 16, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 17, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 17, 2018

Contributor

LGTM, thank you @alu- !

Contributor

mickaelandrieu commented Sep 17, 2018

LGTM, thank you @alu- !

@mickaelandrieu mickaelandrieu merged commit 397fc75 into PrestaShop:develop Sep 17, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment