New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change categories in Module Manager #10440

Merged
merged 33 commits into from Sep 20, 2018

Conversation

@PierreRambaud
Contributor

PierreRambaud commented Sep 14, 2018

Questions Answers
Branch? develop
Description? Follow issue.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10048
Fixes #10251
Fixes #10460
How to test? Follow tickets.

This change is Reviewable

'topMenuData' => $this->getTopMenuData(
$this->get('prestashop.categories_provider')->getCategoriesMenu($installedProducts)
),
'layoutTitle' => $this->trans('Module manager', 'Admin.Modules.Feature'),

This comment has been minimized.

@LouiseBonnard

LouiseBonnard Sep 18, 2018

Contributor

Wouldn't it be better to write Modules manager in the plural, I assume that there are several modules managed here, right?

@LouiseBonnard

LouiseBonnard Sep 18, 2018

Contributor

Wouldn't it be better to write Modules manager in the plural, I assume that there are several modules managed here, right?

This comment has been minimized.

@PierreRambaud

PierreRambaud Sep 18, 2018

Contributor

It was a Lou request :)

@PierreRambaud

PierreRambaud Sep 18, 2018

Contributor

It was a Lou request :)

This comment has been minimized.

@LouToma

LouToma Sep 18, 2018

Yes, no S in English

@LouToma

LouToma Sep 18, 2018

Yes, no S in English

Show outdated Hide outdated ...ShopBundle/Resources/views/Admin/Module/Includes/dropdown_bulk.html.twig Outdated
Show outdated Hide outdated ...ndle/Resources/views/Admin/Module/Includes/dropdown_categories.html.twig Outdated
Show outdated Hide outdated ...restaShopBundle/Resources/views/Admin/Module/Includes/menu_top.html.twig Outdated
Show outdated Hide outdated ...restaShopBundle/Resources/views/Admin/Module/Includes/menu_top.html.twig Outdated
Show outdated Hide outdated ...restaShopBundle/Resources/views/Admin/Module/Includes/see_more.html.twig Outdated
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Module/manage.html.twig Outdated
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Module/manage.html.twig Outdated
Show outdated Hide outdated src/PrestaShopBundle/Resources/views/Admin/Module/manage.html.twig Outdated
"Bulk Action - Request not found": 'The action "[1]" is not available, impossible to perform your request.'|trans({}, 'Admin.Modules.Notification'),
"Bulk Action - Request not available for module": "The action [1] is not available for module [2]. Skipped."|trans({}, 'Admin.Modules.Notification'),
}|merge(js_translatable) %}
"Bulk Action - One module minimum": "You need to select at least one module to use the bulk action."|trans({}, 'Admin.Modules.Notification'),

This comment has been minimized.

@LouiseBonnard

LouiseBonnard Sep 18, 2018

Contributor

Same here, sorryyy.

@LouiseBonnard

LouiseBonnard Sep 18, 2018

Contributor

Same here, sorryyy.

This comment has been minimized.

@LouToma

LouToma Sep 18, 2018

Behaviour remains the same as before

@LouToma

LouToma Sep 18, 2018

Behaviour remains the same as before

@PierreRambaud PierreRambaud changed the title from [WIP] Change categories in Module Manager to Change categories in Module Manager Sep 19, 2018

switchSortingDisplayTo(switchTo) {
if (switchTo !== this.DISPLAY_GRID && switchTo !== this.DISPLAY_LIST) {
console.error(`Can't switch to undefined display property "${switchTo}"`);

This comment has been minimized.

@matks

matks Sep 20, 2018

Contributor

👍

@matks

matks Sep 20, 2018

Contributor

👍

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 20, 2018

use GuzzleHttp\Exception\RequestException;
use PrestaShopBundle\Service\DataProvider\Marketplace\ApiClient;
use Psr\Log\LoggerInterface;
use stdClass;

This comment has been minimized.

@matks

matks Sep 20, 2018

Contributor

I might be wrong but I do not see it being used in this page 😮 ?

@matks

matks Sep 20, 2018

Contributor

I might be wrong but I do not see it being used in this page 😮 ?

This comment has been minimized.

@PierreRambaud

PierreRambaud Sep 20, 2018

Contributor

it is used on line 109.

* @param array|stdClass $categoriesListing Category listing

@PierreRambaud

PierreRambaud Sep 20, 2018

Contributor

it is used on line 109.

* @param array|stdClass $categoriesListing Category listing

$moduleIds[] = $module->attributes->get('id');
}
$categoriesListing = $this->getCategories();
$categories = $this->initializeCategories($categoriesListing);

This comment has been minimized.

@matks

matks Sep 20, 2018

Contributor

👍

@matks

matks Sep 20, 2018

Contributor

👍

@matks

This comment has been minimized.

Show comment
Hide comment
@matks

matks Sep 20, 2018

Contributor

@PierreRambaud I did a review but I think a 2nd one is required as this topic is critical

Contributor

matks commented Sep 20, 2018

@PierreRambaud I did a review but I think a 2nd one is required as this topic is critical

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 20, 2018

Member

Rebased for assets.

Member

Quetzacoalt91 commented Sep 20, 2018

Rebased for assets.

@Quetzacoalt91

Reapplying approval

@PierreRambaud PierreRambaud merged commit 71bab11 into PrestaShop:develop Sep 20, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:improvement/module-manager branch Sep 20, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 20, 2018

Contributor

Thanks me! :trollface:

Contributor

PierreRambaud commented Sep 20, 2018

Thanks me! :trollface:

@marionf marionf removed the Bug label Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment