New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double h1 tag on category page #10447

Merged
merged 7 commits into from Oct 16, 2018

Conversation

Projects
None yet
@MathiasReker
Contributor

MathiasReker commented Sep 15, 2018

Questions Answers
Branch? 1.7.5.x
Description? Double h1 tag when using filters. See #10470
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #10470
How to test? Read ticket

This change is Reviewable

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Sep 16, 2018

You can have many h1 per pages, depends on how to use section tags. I'm not in favor to merge this one.

@PierreRambaud

@colinegin Can you confirm what I said in my comment with SEO team?

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Sep 16, 2018

Why would you want to have more than one h1 tag per page?

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Sep 16, 2018

@Mreker If you use section, you should have split content by section (this is why it's call section ofc). Each section can have a specific title. And even google said it's ok to have multiple h1: https://www.youtube.com/watch?v=WsgrSxCmMbM

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Sep 16, 2018

Thanks for the YouTube video. I did not know about that.

I still think that<p>is better for this title. But I understand the video, so this PR can be closed if you think h1 is best.

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Sep 16, 2018

Maybe some search engine different from Google do not like more than one H1 tag per page.

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Sep 17, 2018

@Mreker This is in the RFC https://tools.ietf.org/html/rfc1866#section-5.4 and google have at least 91% of the global search, and Bing 3.5% and I'm sure they are following the RFC ^^ (http://gs.statcounter.com/search-engine-market-share)

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Sep 17, 2018

Fine with me. Thanks.

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Sep 17, 2018

One more article: http://www.suvaance.com/microblog/how-google-considers-multiple-h1-tags-in-one-page/

As I said in the issue ticket, don't forget we are in HTML5 now ;)

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 12, 2018

Everything ok? :)

@TristanLDD

This comment has been minimized.

TristanLDD commented Oct 12, 2018

Everything's ok for me ! thanks @Mreker

@CaptainYouz

This comment has been minimized.

Contributor

CaptainYouz commented Oct 12, 2018

it's good for me too!

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 12, 2018

@Mreker Do you need help to build assets?

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 12, 2018

@PierreRambaud yes, please. Can you please build it for me?

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 12, 2018

@PierreRambaud Thank you. :)

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 12, 2018

@PierreRambaud You built assets for js, not css?

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 12, 2018

@Mreker Done, and Yes I was building the wrong directory =)

@marionf marionf self-assigned this Oct 12, 2018

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 12, 2018

@marionf marionf removed their assignment Oct 12, 2018

@Quetzacoalt91

N/A on StarterTheme

@PierreRambaud PierreRambaud merged commit 51c870d into PrestaShop:1.7.5.x Oct 16, 2018

1 of 2 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 16, 2018

Thanks @Mreker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment