New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal error while adding tags #10448

Merged
merged 2 commits into from Sep 21, 2018

Conversation

Projects
None yet
6 participants
@MathiasReker
Contributor

MathiasReker commented Sep 15, 2018

Questions Answers
Branch? 1.7.5.x
Description? Fatal error occurs when $data variable happens to be empty, commonly when used with import addons.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #9278
How to test? @vytsci

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 16, 2018

Contributor

Hello @Mreker,

don't worry about fixing Coding Standards manually, use this command instead:

./vendor/bin/php-cs-fixer fix

This will fix everything, then you just need to commit the changes 👍

Contributor

mickaelandrieu commented Sep 16, 2018

Hello @Mreker,

don't worry about fixing Coding Standards manually, use this command instead:

./vendor/bin/php-cs-fixer fix

This will fix everything, then you just need to commit the changes 👍

MathiasReker and others added some commits Sep 15, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Sep 16, 2018

@eternoendless eternoendless changed the base branch from develop to 1.7.5.x Sep 21, 2018

@eternoendless

This comment has been minimized.

Show comment
Hide comment
@eternoendless

eternoendless Sep 21, 2018

Member

Thank you @Mreker

Member

eternoendless commented Sep 21, 2018

Thank you @Mreker

@eternoendless eternoendless merged commit 7be7adf into PrestaShop:1.7.5.x Sep 21, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment