New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong display of the brand page #10462

Merged
merged 1 commit into from Sep 27, 2018

Conversation

Projects
None yet
7 participants
@khouloudbelguith
Contributor

khouloudbelguith commented Sep 17, 2018

Questions Answers
Branch? 1.7.5.x
Description? When we try to add a new brand, the description & the logo are not aligned.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10461
How to test? Go to BO => Catalog => Brands page => Click on 'add a new brand'

This change is Reviewable

@mbadrani

This comment has been minimized.

Show comment
Hide comment
@mbadrani

mbadrani Sep 19, 2018

Contributor

@eternoendless this PR has been well checked by Reddy but it need Dev to review the code

Contributor

mbadrani commented Sep 19, 2018

@eternoendless this PR has been well checked by Reddy but it need Dev to review the code

@ntiepresta ntiepresta self-assigned this Sep 19, 2018

@mbadrani mbadrani added Code ✔️ and removed waiting for QA labels Sep 19, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 26, 2018

Contributor

@khouloudbelguith as you fix a regression, I think this PR should be on 1.7.5.x branch

Contributor

marionf commented Sep 26, 2018

@khouloudbelguith as you fix a regression, I think this PR should be on 1.7.5.x branch

@khouloudbelguith khouloudbelguith changed the base branch from develop to 1.7.5.x Sep 26, 2018

@khouloudbelguith

This comment has been minimized.

Show comment
Hide comment
@khouloudbelguith

khouloudbelguith Sep 26, 2018

Contributor

@marion Done.
Thanks!

Contributor

khouloudbelguith commented Sep 26, 2018

@marion Done.
Thanks!

@marionf marionf added this to the 1.7.5.0 milestone Sep 26, 2018

@PierreRambaud PierreRambaud merged commit d030a50 into PrestaShop:1.7.5.x Sep 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Sep 27, 2018

Thanks @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment