New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: classic theme footer block design #10483 #10484

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
4 participants
@rdy4ever
Contributor

rdy4ever commented Sep 19, 2018

Fix for #10483

Questions Answers
Branch? develop
Description? As reported in #10483, the footer columns are not eavenly distributed to the bootstrap 12 col grid (there is an extra 2 col space).
Type? improvement
Category? FO
BC breaks? Does it break backward compatibility?no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? #10483
How to test? Check the footer column distribution. Now the 12 column grid is complete.
image

This change is Reviewable

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 19, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit f91d5f2 into PrestaShop:develop Sep 19, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Sep 19, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 19, 2018

Thank you @rdy4ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment