New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split grid service definitions in separate files #10486

Merged
merged 3 commits into from Dec 18, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Copy link
Member

sarjon commented Sep 19, 2018

Questions Answers
Branch? develop
Description? grid.yml is getting bigger and bigger with each migrated page, so it would be nice to split grid services into different files.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? All new list (grid) pages should be working.

This change is Reviewable

@matks matks added the migration label Sep 19, 2018

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Sep 20, 2018

@mickaelandrieu mickaelandrieu changed the title Split grid service definitions in separete files Split grid service definitions in separate files Sep 21, 2018

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Oct 18, 2018

@sarjon Idea is great 👍 however I think since this PR was done 29 days ago, now src/PrestaShopBundle/Resources/config/services/core/grid.yml has probably grown again. Shall we redo the PR for the update grid.yml ?

I promise I will merge it quick 🙏

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Dec 10, 2018

ping @sarjon 👼

@sarjon sarjon force-pushed the sarjon:update-grid-services-structure branch from 3f7afa4 to c942bc7 Dec 17, 2018

@sarjon

This comment has been minimized.

Copy link
Member

sarjon commented Dec 17, 2018

@matks i've rebased it, would be nice to merge it. :)

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 18, 2018

No need for QA as I tested using Symfony container dumps

@matks

matks approved these changes Dec 18, 2018

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Dec 18, 2018

Thanks @sarjon

@matks matks merged commit 1aaffbe into PrestaShop:develop Dec 18, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment