New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #10535

Merged
merged 6 commits into from Oct 26, 2018

Conversation

Projects
None yet
8 participants
@MathiasReker
Contributor

MathiasReker commented Sep 20, 2018

Questions Answers
Branch? develop
Description? Fix text
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10534
How to test? Go to usefull links in BO

This change is Reviewable

MathiasReker added some commits Sep 11, 2018

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Sep 20, 2018

@colinegin @eternoendless What do you think?

@khouloudbelguith

This comment has been minimized.

Contributor

khouloudbelguith commented Sep 20, 2018

Fixed by #10151

@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Sep 20, 2018

#10535 fix typo
#10151 fix url

@colinegin

This comment has been minimized.

colinegin commented Sep 20, 2018

@eternoendless @LouiseBonnard didn't we say we keep the generic word "Bug Tracker" in order to avoid wording changes if we use new tools in the future ?

@LouiseBonnard

This comment has been minimized.

Contributor

LouiseBonnard commented Sep 20, 2018

@eternoendless, @colinegin, what about Report issues? Without any further details, we will be free to use new tools in the future without adapting the wording.

<source>Report issues in the Bug Tracker</source>
<target>Report issues in the Bug Tracker</target>
<source>Report issues on GitHub</source>
<target>Report issues on GitHub</target>

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Sep 20, 2018

Member

These changes are not needed, as they will be regenerated later.

This comment has been minimized.

@MathiasReker

MathiasReker Sep 21, 2018

Contributor

Fixed :)

fix
@MathiasReker

This comment has been minimized.

Contributor

MathiasReker commented Oct 12, 2018

Can I do anything? :)

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 25, 2018

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Oct 26, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 3ac0998 into PrestaShop:develop Oct 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 26, 2018

Thank you @MathiasReker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment