New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attr('data-') instead of data #10601

Merged
merged 2 commits into from Sep 24, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Contributor

PierreRambaud commented Sep 21, 2018

Questions Answers
Branch? 1.7.5.x
Description? We need to use attr('data- instead of data to open modal..
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10598
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

@PierreRambaud PierreRambaud changed the title from use attr('data-') instead of data, weird :/ to use attr('data-') instead of data Sep 21, 2018

@eternoendless eternoendless changed the base branch from develop to 1.7.5.x Sep 21, 2018

@eternoendless eternoendless changed the title from use attr('data-') instead of data to Use attr('data-') instead of data Sep 21, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 21, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 0dfc590 into PrestaShop:1.7.5.x Sep 24, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 24, 2018

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/10598 branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment