New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FO: Fix password validation message #10643

Merged
merged 6 commits into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@rdy4ever
Contributor

rdy4ever commented Sep 22, 2018

Questions Answers
Branch? develop
Description? There was no description for the password browser validation message if a password was too short. This PR adds a short message for the user.
Type? bug fix
Category? FO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? (optional) If this PR fixes an Issue, please write "Fixes #[issue number]" here.
How to test? Try to create an account with a short password (<5). See before/after comparison
Before: image
After: image

This change is Reviewable

rdy4ever added some commits Sep 20, 2018

FO: fix password field browser validation message
This PR fixes the broswer validation incomplete message for password fields.

@rdy4ever rdy4ever changed the title from FO: Fix password validation message to FO: Fix password validation message and birthday filed Sep 22, 2018

rdy4ever added some commits Sep 22, 2018

Revert "isset"
This reverts commit b10e682.
Revert "Fix birthday input"
This reverts commit d818b42.

@rdy4ever rdy4ever changed the title from FO: Fix password validation message and birthday filed to FO: Fix password validation message Sep 22, 2018

@rdy4ever

This comment has been minimized.

Show comment
Hide comment
@rdy4ever

rdy4ever Sep 22, 2018

Contributor

Setting the birthday field type to "date" creates unexpected results depending on the language date format. OK for any date formats using "-" as separator and for default english format, NOK for other using "/" as separator but in different order. Reverting changes.

Contributor

rdy4ever commented Sep 22, 2018

Setting the birthday field type to "date" creates unexpected results depending on the language date format. OK for any date formats using "-" as separator and for default english format, NOK for other using "/" as separator but in different order. Reverting changes.

@marionf marionf removed the waiting for QA label Sep 24, 2018

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Sep 26, 2018

@PierreRambaud PierreRambaud merged commit 2b550d6 into PrestaShop:develop Sep 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 26, 2018

Contributor

Thanks @rdy4ever

Contributor

PierreRambaud commented Sep 26, 2018

Thanks @rdy4ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment