New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attr('data-') instead of data #10658

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
4 participants
@PierreRambaud
Contributor

PierreRambaud commented Sep 24, 2018

Questions Answers
Branch? develop
Description? We need to use attr('data- instead of data to open modal..
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10598
How to test? Follow ticket instruction.

This change is Reviewable

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 24, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 18d0d30 into PrestaShop:develop Sep 26, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/10598 branch Sep 26, 2018

@marionf marionf modified the milestone: 1.7.5.0 Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment