New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getcwd() for __DIR__ #10699

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
5 participants
@DanielBoettner
Contributor

DanielBoettner commented Sep 25, 2018

Questions Answers
Branch? develop
Description? Changing getwd() to DIR , so the path in PS_ADMIN_DIR is the absolute path. Which for example makes it easier to create cronjobs
Type? improvement
Category? CO
BC breaks? It should not break anything, the path is just more flexible
Deprecations? no
Fixed ticket? Fixes #10697
How to test? run e.g. php -f admin/index.php "controller=AdminCronJobs token={mytoken}"

This change is Reviewable

Change getcwd() for __DIR__
Changing getwd() to __DIR__ , so the path in _PS_ADMIN_DIR_ is the absolute path.
@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Sep 25, 2018

Hello @DanielBoettner!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 3, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit cd64466 into PrestaShop:develop Oct 3, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 3, 2018

Thank you @DanielBoettner

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment