New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move position column template #10705

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
6 participants
@jolelievre
Contributor

jolelievre commented Sep 25, 2018

Questions Answers
Branch? 1.7.5.x
Description? The former macros for grid have been removed, we now use a twig extension which expects the column template to be in @PrestaShop/Admin/Common/Grid/Columns/Content
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Required for #9746
How to test?

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.0 milestone Sep 25, 2018

@marionf

This comment has been minimized.

Show comment
Hide comment
@marionf

marionf Sep 25, 2018

Contributor

@jolelievre Is there anything functional to test ? Or a specific page that I can check to see if there isn't regression ?

Contributor

marionf commented Sep 25, 2018

@jolelievre Is there anything functional to test ? Or a specific page that I can check to see if there isn't regression ?

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 25, 2018

Contributor

unfortunately no, this type of comun is only used in the ps_linklist module for now
and I don't know of any tests for the grid rendering, although there are a few Integration tests for some of the migrated controller but they don't test this specific type of column

Contributor

jolelievre commented Sep 25, 2018

unfortunately no, this type of comun is only used in the ps_linklist module for now
and I don't know of any tests for the grid rendering, although there are a few Integration tests for some of the migrated controller but they don't test this specific type of column

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 25, 2018

Contributor

sorry I misunderstood your question, I thought you were refering to automatic tests

so, you will need this PR modifications if you want to test the pending PR on the ps_linklist module PrestaShop/ps_linklist#48

Contributor

jolelievre commented Sep 25, 2018

sorry I misunderstood your question, I thought you were refering to automatic tests

so, you will need this PR modifications if you want to test the pending PR on the ps_linklist module PrestaShop/ps_linklist#48

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 26, 2018

@matks matks added the migration label Sep 26, 2018

@PierreRambaud PierreRambaud merged commit d0248c3 into PrestaShop:1.7.5.x Sep 26, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Sep 26, 2018

Thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment