New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fixes to the script #10708

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
6 participants
@hadrich-hatem
Contributor

hadrich-hatem commented Sep 25, 2018

Questions Answers
Branch? 1.7.4.x
Description? This PR adds some fixes to script.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@hadrich-hatem hadrich-hatem changed the base branch from develop to 1.7.4.x Sep 25, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 3, 2018

Hi @hadrich-hatem,

What about 1.7.5.x branch?

@PierreRambaud

This comment has been minimized.

Contributor

PierreRambaud commented Oct 3, 2018

Or develop?

@hadrich-hatem

This comment has been minimized.

Contributor

hadrich-hatem commented Oct 3, 2018

Hi @Quetzacoalt91,

Just there are some fixes that I will add on 1.7.5.x. So, i will close this PR and i will open another one.

Best regards,

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 4, 2018

Nice, having these tests on 1.7.5.x (or develop) would be better, as they are the current active branches.

I'm closing this one while you re-suggest the changes to the other branch.

Regards

@fatmaBouchekoua

This comment has been minimized.

Contributor

fatmaBouchekoua commented Oct 31, 2018

Hello @Quetzacoalt91 ,
I reopen this PR because there's a new pre-release 1.7.4.4.
Can you merge it please so we can run tests on this pre-release?

Thanks !

@fatmaBouchekoua fatmaBouchekoua added the TE label Oct 31, 2018

@mbadrani

Needed for test campaign execution

@mbadrani mbadrani merged commit 9170a3d into PrestaShop:1.7.4.x Oct 31, 2018

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment