New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests if Addons API doesn't give us modules #10716

Merged
merged 5 commits into from Sep 26, 2018

Conversation

Projects
None yet
5 participants
@PierreRambaud
Contributor

PierreRambaud commented Sep 26, 2018

Questions Answers
Branch? 1.7.5.x
Description? Try to fix tests
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? Wait for travis ci.

This change is Reviewable

@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.5.x Sep 26, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 26, 2018

@jolelievre

weird to see all these changes, the tests should have crashed long ago if all these changes are needed? or were they inactive?

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 26, 2018

Contributor

@jolelievre The tests should have crashed long ago without Addons API modules avaiable :/ For the function isLoadedObject I really don't find why it's not working now, really really weird, maybe we tried with module containing an ->id (and having some luck)

Contributor

PierreRambaud commented Sep 26, 2018

@jolelievre The tests should have crashed long ago without Addons API modules avaiable :/ For the function isLoadedObject I really don't find why it's not working now, really really weird, maybe we tried with module containing an ->id (and having some luck)

@matks matks merged commit 239ad41 into PrestaShop:1.7.5.x Sep 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/tests branch Sep 26, 2018

@matks matks referenced this pull request Sep 26, 2018

Merged

Add TranslatableType #10704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment