New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing styles on empty state SEO & Traffic page #10718

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
6 participants
@CaptainYouz
Contributor

CaptainYouz commented Sep 26, 2018

Questions Answers
Branch? 1.7.5.x
Description? This PR add the missing styles in empty states SEO.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #10683
How to test? Check before after

This change is Reviewable

@CaptainYouz CaptainYouz changed the title from Issue 10683 empty state styles to Add missing styles on empty state SEO & Traffic page Sep 26, 2018

img {
animation: showcase-img-appereance 1.5s;

This comment has been minimized.

@matks

matks Sep 26, 2018

Contributor

appereance => appearance

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 16, 2018

@CaptainYouz I guess this PR should be on 1.7.5.x branch?

@Quetzacoalt91 Quetzacoalt91 changed the base branch from develop to 1.7.5.x Oct 16, 2018

@Quetzacoalt91 Quetzacoalt91 changed the base branch from 1.7.5.x to develop Oct 16, 2018

@Quetzacoalt91 Quetzacoalt91 changed the base branch from develop to 1.7.5.x Oct 16, 2018

Taken in account

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 16, 2018

@matks, your comments have been applied.

PR rebased on 1.7.5.x and conflicts resolved

@marionf marionf removed the waiting for QA label Oct 17, 2018

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Oct 17, 2018

Rebased

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.0 milestone Oct 17, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit e8b2604 into PrestaShop:1.7.5.x Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment