New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide delete button on ordered cart #10725

Merged
merged 1 commit into from Sep 27, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Sep 26, 2018

Questions Answers
Branch? 1.7.5.x
Description? You can not delete a cart which has been ordered, and if you try it you get an error (luckily) But the button was displayed never the less So now it is displayed only if you can delete it
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10599
How to test?

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 26, 2018

Member

@jolelievre, you marked this PR for 1.7.5.x, but this PR targets the branch develop.

Member

Quetzacoalt91 commented Sep 26, 2018

@jolelievre, you marked this PR for 1.7.5.x, but this PR targets the branch develop.

@PierreRambaud PierreRambaud changed the base branch from develop to 1.7.5.x Sep 26, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 26, 2018

@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 26, 2018

Contributor

I changed it because of related issue.

Contributor

PierreRambaud commented Sep 26, 2018

I changed it because of related issue.

@jolelievre

This comment has been minimized.

Show comment
Hide comment
@jolelievre

jolelievre Sep 26, 2018

Contributor

@Quetzacoalt91 I thought we merged bugs in 1.7.5.x first, then we merge back 1.7.5.x to develop

Contributor

jolelievre commented Sep 26, 2018

@Quetzacoalt91 I thought we merged bugs in 1.7.5.x first, then we merge back 1.7.5.x to develop

@marionf marionf added QA ✔️ and removed waiting for QA labels Sep 27, 2018

@Quetzacoalt91 Quetzacoalt91 merged commit 544bd62 into PrestaShop:1.7.5.x Sep 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Sep 27, 2018

Thank you @jolelievre

@jolelievre jolelievre changed the title from hide delete button on ordered cart to Hide delete button on ordered cart Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment