New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterParametersUpdater manages filters in a better way #10728

Merged
merged 5 commits into from Sep 29, 2018

Conversation

Projects
None yet
5 participants
@jolelievre
Contributor

jolelievre commented Sep 26, 2018

Questions Answers
Branch? 1.7.5.x
Description? FilterParametersUpdater manages overriding between request, persisted and default parameters in list and catalog
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10703
Fixes #10257
How to test? Go to Catalog > Products, test the filters in the list you will see that they work, then go to a product page Click on the product list you will see the last list of products you had in the catalog

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.0 milestone Sep 26, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Sep 29, 2018

Contributor

Thanks !

Contributor

mickaelandrieu commented Sep 29, 2018

Thanks !

@PierreRambaud PierreRambaud merged commit 3fa35c9 into PrestaShop:1.7.5.x Sep 29, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud
Contributor

PierreRambaud commented Sep 29, 2018

Thanks @jolelievre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment