New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module translations aren't working when using Smarty Extend into TPL in BO #10735

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@PierreRambaud
Contributor

PierreRambaud commented Sep 27, 2018

Questions Answers
Branch? 1.7.5.x
Description? Currently the selected source is the extend module. Always use $smarty->resource->name to retrieve the template name
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9525
How to test? Follow ticket instructions.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Sep 27, 2018

@ntiepresta ntiepresta self-assigned this Sep 28, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 28, 2018

@PierreRambaud PierreRambaud merged commit e465485 into PrestaShop:1.7.5.x Oct 1, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/translation-9525 branch Oct 1, 2018

@ntiepresta ntiepresta removed their assignment Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment