New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not display product Reference if empty #10750

Merged
merged 2 commits into from Oct 2, 2018

Conversation

Projects
None yet
5 participants
@khouloudbelguith
Contributor

khouloudbelguith commented Sep 28, 2018

Questions Answers
Branch? 1.7.5.x
Description? Bug fix on FO product details display
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #10749
How to test? Create a new product with an empty reference. Go to the FO to see this product, in the Product Details tab you will see the text "Reference" with nothing below.

This change is Reviewable

@prestamodule

This comment has been minimized.

Contributor

prestamodule commented Oct 1, 2018

@khouloudbelguith empty() does not mean empty string, for example, "0" will be considered as empty. You should maybe check length instead ?

@eternoendless eternoendless added this to the 1.7.5.0 milestone Oct 1, 2018

@marionf

This comment has been minimized.

Contributor

marionf commented Oct 2, 2018

@khouloudbelguith

When a product has combinations and if I enter a specific ref for a combination, it's the general ref displayed instead of the specific one

capture d ecran_362

capture d ecran_363

@khouloudbelguith

This comment has been minimized.

Contributor

khouloudbelguith commented Oct 2, 2018

Hi @marionf,

This is another issue, it is a regression in the 1.7.5.x.
This PR checks only if the reference is empty.
Should I create another issue on 1.7.5.x?

Best regards, Khouloud

@marionf marionf added QA ✔️ and removed waiting for author labels Oct 2, 2018

@marionf

This comment has been minimized.

Contributor

marionf commented Oct 2, 2018

@khouloudbelguith
I created a new issue

@eternoendless

This comment has been minimized.

Member

eternoendless commented Oct 2, 2018

Thank you @khouloudbelguith

@eternoendless eternoendless merged commit cb6c8ac into PrestaShop:1.7.5.x Oct 2, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment