New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No unset id_attribute, could be usefull to theme development #10769

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
5 participants
@Piraito
Contributor

Piraito commented Sep 29, 2018

Questions Answers
Branch? develop
Description? Why unset a previously setted variable without a good reason? For example, I use this id_attribute value, using a module, to filter images by attribute in lists of products. You can see it in action at https://piraito.com if you click in a color/model attribute, images matching this attribute are showed.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
How to test? In variant-links.tpl adding at the beginning {$variants|dump} you can see info array associated with every attribute showed

This change is Reviewable

No unset id_attribute, could be usefull to theme development
For example, I use this id_attribute value to filter images by attribute in lists of products, using a module. You can see it in action at piraito.com if you click in a color/model attribute, images matching this attribute are showed.
@prestonBot

This comment has been minimized.

Collaborator

prestonBot commented Sep 29, 2018

Hello @Piraito!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@marionf marionf added QA ✔️ and removed waiting for QA labels Oct 4, 2018

@matks matks merged commit e6d22f3 into PrestaShop:develop Oct 8, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks

This comment has been minimized.

Contributor

matks commented Oct 8, 2018

Thanks @Piraito and nice shop !

@matks matks added this to the 1.7.6.0 milestone Oct 8, 2018

@Piraito Piraito deleted the Piraito:patch-2 branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment